Skip to content

add {PROVIDER}_DISPLAY_NAME env-var #8967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

n1cc00
Copy link
Contributor

@n1cc00 n1cc00 commented May 16, 2025

This environment variable is added to the front-service to allow setting a custom provider name for OpenId Login button:

huly_openiddisplayname

@n1cc00 n1cc00 force-pushed the customize-openid-login-button branch from 3687036 to dbcd12d Compare May 16, 2025 08:15
Copy link

Connected to Huly®: UBERF-10629

1 similar comment
Copy link

Connected to Huly®: UBERF-10629

@n1cc00 n1cc00 force-pushed the customize-openid-login-button branch from 510a8f6 to 112a908 Compare May 16, 2025 13:07
Copy link
Collaborator

@lexiv0re lexiv0re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Could you please also attach a screenshot of how it looks when configured with a custom name.

@n1cc00 n1cc00 force-pushed the customize-openid-login-button branch 2 times, most recently from 36b8cf2 to 7a6525f Compare May 16, 2025 17:22
…on (configurable via *_PROVIDER_NAME)

Signed-off-by: nicolasschneider <[email protected]>
@n1cc00 n1cc00 force-pushed the customize-openid-login-button branch from 7a6525f to c313db2 Compare May 19, 2025 09:31
@n1cc00 n1cc00 changed the title add OPENID_DISPLAY_NAME env-var add {PROVIDER}_DISPLAY_NAME env-var May 19, 2025
@n1cc00 n1cc00 requested a review from lexiv0re May 19, 2025 11:47
@n1cc00 n1cc00 force-pushed the customize-openid-login-button branch from 4330d7a to 00d9719 Compare May 21, 2025 10:39
@n1cc00 n1cc00 requested a review from lexiv0re May 21, 2025 10:41
Signed-off-by: nicolasschneider <[email protected]>
@n1cc00
Copy link
Contributor Author

n1cc00 commented May 23, 2025

I have a question about formatting: I tried running ESLint, but it didn’t change Providers.svelte, and running Prettier completely changed the files in the wrong way (not following the correct formatting style). So for now, I applied the changes manually. What’s the correct command to fix files properly ?

@lexiv0re
Copy link
Collaborator

It's rush fast-format for the whole repo or rushx format for a particular package.

Copy link
Collaborator

@lexiv0re lexiv0re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lexiv0re lexiv0re merged commit 8b6b106 into hcengineering:develop May 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants